FEATURE: translate topic #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, only posts are being translated. When a post is the first post, we should include information about the topic. Meta https://meta.discourse.org/t/feature-request-topic-title-translation/144714
nattsw
reviewed
Dec 28, 2023
nattsw
approved these changes
Dec 28, 2023
There was a problem hiding this comment.
I am not sure.
I feel like we can put the translate button before the topic title?
There are some outlets for us to use. (see after-topic-status and topic-title)
I am on the fence. I think this works as-is, but it is weird translating topic title in the post. I am going to approve but I feel we can do better. What do you think?
🧐
|
Good point, UI in that case is a bit weird. On the other hand, I feel the user would like to see the translation for both and with the current design there is 1 click vs 2 clicks 🤷♂️ The current UI was suggested by user https://meta.discourse.org/t/feature-request-topic-title-translation/144714 I think we can try merging it and collect feedback on the meta. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, only posts are being translated. When a post is the first post, we should include information about the topic.
Meta https://meta.discourse.org/t/feature-request-topic-title-translation/144714
Demo