DEV: Update rubocop-discourse to latest version #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CvX
approved these changes
May 17, 2024
| extend ActiveSupport::Concern | ||
|
|
||
| def can_create_post_on_topic?(topic) | ||
| return super if !SiteSetting.restricted_replies_enabled |
There was a problem hiding this comment.
Are enabled checks required in class extensions?
There was a problem hiding this comment.
When adding methods to existing classes, we should check for the enabled setting, yes. It’s not done automatically when extending “manually” a class, so we should probably keep the existing checks when they exist. (Maybe at some point we could do something to automatically add the checks)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.