Adds approx guild count and get self application endpoint #5971

Jupith · 2023-03-02T10:11:29Z

No description provided.

splatterxl · 2023-03-02T17:18:24Z

docs/resources/Application.md

@@ -19,11 +19,13 @@
 | summary *(deprecated)*             | string                                                                     | **deprecated and will be removed in v11.** An empty string.                                                                                                                 |
 | verify_key                         | string                                                                     | the hex encoded key for verification in interactions and the GameSDK's [GetTicket](#DOCS_GAME_SDK_APPLICATIONS/getticket)                                                   |
 | team                               | ?[team](#DOCS_TOPICS_TEAMS/data-models-team-object) object                 | if the application belongs to a team, this will be a list of the members of that team                                                                                       |
-| guild_id?                          | snowflake                                                                  | if this application is a game sold on Discord, this field will be the guild to which it has been linked                                                                     |
+| guild_id?                          | snowflake                                                                  | guild associated with the bot. For example a developer support server.                                                                                                      |


splatterxl · 2023-03-02T17:18:54Z

docs/resources/Application.md

 | primary_sku_id?                    | snowflake                                                                  | if this application is a game sold on Discord, this field will be the id of the "Game SKU" that is created, if exists                                                       |
 | slug?                              | string                                                                     | if this application is a game sold on Discord, this field will be the URL slug that links to the store page                                                                 |
 | cover_image?                       | string                                                                     | the application's default rich presence invite [cover image hash](#DOCS_REFERENCE/image-formatting)                                                                         |
 | flags?                             | integer                                                                    | the application's public [flags](#DOCS_RESOURCES_APPLICATION/application-object-application-flags)                                                                          |
+| approximate_guild_count?           | integer                                                                    | an approximate count of the bots guild membership.                                                                                                                          |


"an application" doesn't really match the rest, it should be "the application", like how the current docs say "the bots"

either way it's not a count of app membership, just bot.

maybe something like an approximate count of the guilds the bot was added to

TTtie · 2023-03-02T18:39:00Z

docs/resources/Application.md

@@ -94,3 +96,7 @@
 | ----------- | ---------------- | ---------------------------------------------------------------------------------------------------------- |
 | scopes      | array of strings | the [scopes](#DOCS_TOPICS_OAUTH2/shared-resources-oauth2-scopes) to add the application to the server with |
 | permissions | string           | the [permissions](#DOCS_TOPICS_PERMISSIONS) to request for the bot role                                    |
+
+## Get Current Bot Application Information % GET /applications/@me


Hey there, what is going to happen to the /oauth2/applications/@me route? Is it still going to be supported, or is it going to be deprecated and eventually replaced with this route?

Nothing changes here. It was just not documented.

docs/resources/Application.md

Co-authored-by: IllagerCaptain <76600137+IllagerCaptain@users.noreply.github.com>

Misha-133 · 2023-03-02T20:17:05Z

What about redirect_uris (array of string) and interactions_endpoint_url (string) properties? They are also returned on this endpoint. Shouldn't these be documented too?

After doing some more research it seems like this endpoint also returns a partial guild object if one is linked as a support server for the bot

Also bot_public and bot_require_code_grant should be marked as optionals since they are not returned

Jupith · 2023-03-03T18:27:10Z

What about redirect_uris (array of string) and interactions_endpoint_url (string) properties? They are also returned on this endpoint. Shouldn't these be documented too?

I can document those aswell sure, the endpoint actually supports PATCH, these 2 are params.

After doing some more research it seems like this endpoint also returns a partial guild object if one is linked as a support server for the bot

I included this

Also bot_public and bot_require_code_grant should be marked as optionals since they are not returned

👍

Misha-133 · 2023-03-03T19:03:02Z

I included this

Ah, yup, sorry. I've completely missed it

I can document those aswell sure, the endpoint actually supports PATCH, these 2 are params.

huh, setting redirect_uris doesn't seem to change anything

interactions_endpoint_url and role_connections_verification_url change without issues tho
description changes as well

Jupith · 2023-03-03T19:19:42Z

huh, setting redirect_uris doesn't seem to change anything

Oh yeah, i got confused because they still validate it, so it looks settable :husk:

Lulalaby · 2023-03-03T20:19:24Z

huh, setting redirect_uris doesn't seem to change anything

Oh yeah, i got confused because they still validate it, so it looks settable :husk:

So is it settable or not 😅

Jupith · 2023-03-03T20:24:24Z

If your a user yea, but not for bots

IllagerCaptain · 2023-03-03T20:48:28Z

If your a user yea, but not for bots

I'm assuming this is for user security w/ OAuth2 in the case of a token leak?

Lulalaby · 2023-03-03T20:52:36Z

If your a user yea, but not for bots

Ah yeah, tested it, thanks for the clarification

Misha-133 · 2023-03-04T15:02:50Z

So it appears that you can also modify application's tags
and each tag has a max length of 20.

And also you can edit icon with a base64 encoded image

Puncher1 · 2023-03-09T09:45:05Z

For me the response doesn't have the approximate_guild_count field.

Repro:

import aiohttp
import asyncio
import os

from dotenv import load_dotenv

load_dotenv()


TOKEN = os.getenv("BOT_TOKEN")
BASE = "https://discord.com/api/v10"
HEADERS = {
    'User-Agent': 'DiscordBot (https://github.com/puncher1, 1) Python/3.8 aiohttp/3.8.4',
    'Authorization': f'Bot {TOKEN}',
    'Content-Type': 'application/json'
}

async def request(method, url, **kwargs):
    session = aiohttp.ClientSession()
    async with session.request(method, url, **kwargs) as response:
        text = await response.text(encoding='utf-8')
        print(text)


def get_appinfo():
    method = "GET"
    url =f"{BASE}/oauth2/applications/@me"
    kwargs = {'headers': HEADERS,}

    asyncio.run(request(method, url, **kwargs))

get_appinfo()

Lulalaby · 2023-03-09T09:47:09Z

Fyi the apps @me endpoint is missing important data like teams and owner.

Should not be used as replacement for the oauth route.

advaith1 · 2023-03-09T09:47:17Z

@Puncher1 /oauth2/applications/@me and /applications/@me are different endpoints

Puncher1 · 2023-03-09T09:54:03Z

@advaith1 Ah alright. Can you send me a link to the documentation? I can only find GET /oauth2/applications/@me

advaith1 · 2023-03-09T09:55:09Z

It is not released yet so it is intentionally not documented yet. The point of this PR is to document it

Puncher1 · 2023-03-09T09:58:51Z

@advaith1 Ah okay, thanks for clarity. I thought it's only related to /oauth2/applications/@me. So applications/@me is a partial application info?

Lulalaby · 2023-03-09T10:00:56Z

docs/resources/Application.md

+
+## Get Current Bot Application Information % GET /applications/@me
+
+Returns the bot's [application](#DOCS_RESOURCES_APPLICATION/application-object) object.


Would add a note that the info returned from this endpoint is partial/different from the oauth2 route

shaydewael

standardizing on app since it's Application object 😅

docs/resources/Application.md

Co-authored-by: shay <swdewael@gmail.com>

See discord/discord-api-docs#5971.

See discord/discord-api-docs#5971

* Add endpoint * Add new fields * Update docs/resources/Application.md Co-authored-by: IllagerCaptain <76600137+IllagerCaptain@users.noreply.github.com> * Update docs/resources/Application.md Co-authored-by: shay <swdewael@gmail.com> * Update docs/resources/Application.md Co-authored-by: shay <swdewael@gmail.com> * Update docs/resources/Application.md Co-authored-by: shay <swdewael@gmail.com> * Update docs/resources/Application.md Co-authored-by: shay <swdewael@gmail.com> --------- Co-authored-by: IllagerCaptain <76600137+IllagerCaptain@users.noreply.github.com> Co-authored-by: shay <swdewael@gmail.com>

Jupith added 2 commits March 2, 2023 09:58

Add endpoint

3114e7a

Add new fields

2e92e72

almeidx mentioned this pull request Mar 2, 2023

feat(APIApplication): approx guild count and get self application endpoint discordjs/discord-api-types#728

Merged

splatterxl reviewed Mar 2, 2023

View reviewed changes

TTtie reviewed Mar 2, 2023

View reviewed changes

IllagerCaptain reviewed Mar 2, 2023

View reviewed changes

docs/resources/Application.md Outdated Show resolved Hide resolved

Update docs/resources/Application.md

4eb1727

Co-authored-by: IllagerCaptain <76600137+IllagerCaptain@users.noreply.github.com>

Misha-133 mentioned this pull request Mar 2, 2023

[Feature] Get current bot application information discord-net/Discord.Net#2619

Merged

Lulalaby reviewed Mar 9, 2023

View reviewed changes

shaydewael requested changes Jul 13, 2023

View reviewed changes

docs/resources/Application.md Outdated Show resolved Hide resolved

docs/resources/Application.md Outdated Show resolved Hide resolved

docs/resources/Application.md Outdated Show resolved Hide resolved

docs/resources/Application.md Outdated Show resolved Hide resolved

Jupith and others added 4 commits July 13, 2023 20:30

Update docs/resources/Application.md

cbc92ee

Co-authored-by: shay <swdewael@gmail.com>

Update docs/resources/Application.md

307897f

Co-authored-by: shay <swdewael@gmail.com>

Update docs/resources/Application.md

5b7136e

Co-authored-by: shay <swdewael@gmail.com>

Update docs/resources/Application.md

40a8d16

Co-authored-by: shay <swdewael@gmail.com>

shaydewael approved these changes Jul 13, 2023

View reviewed changes

shaydewael merged commit 0817246 into discord:main Jul 13, 2023
2 checks passed

Nihlus added a commit to Remora/Remora.Discord that referenced this pull request Jul 14, 2023

Implement approximate guild count and partial guild.

88f69d4

See discord/discord-api-docs#5971.

Jiralite mentioned this pull request Jul 14, 2023

feat(ClientApplication): Approximate guild count and new GET route discordjs/discord.js#9713

Merged

jocafamaka mentioned this pull request Jul 15, 2023

Update APPLICATION_CURRENT endpoint discord-php/DiscordPHP-Http#22

Merged

sebm253 mentioned this pull request Jul 16, 2023

Update Applications disgoorg/disgo#290

Merged

TTtie mentioned this pull request Jul 25, 2023

feat: add Client#getApplication() projectdysnomia/dysnomia#90

Merged

Jiralite mentioned this pull request Aug 22, 2023

feat: Implement GET current application discordjs/discord.js#9797

Merged

lukellmann added a commit to lukellmann/kord that referenced this pull request Sep 28, 2023

wip

9e9ea22

See discord/discord-api-docs#5971

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds approx guild count and get self application endpoint #5971

Adds approx guild count and get self application endpoint #5971

Jupith commented Mar 2, 2023

splatterxl Mar 2, 2023 •

edited

Loading

splatterxl Mar 2, 2023 •

edited

Loading

ooliver1 Mar 2, 2023

Jupith Mar 2, 2023

Lulalaby Mar 2, 2023

TTtie Mar 2, 2023

Lulalaby Mar 2, 2023

Misha-133 commented Mar 2, 2023 •

edited

Loading

Jupith commented Mar 3, 2023

Misha-133 commented Mar 3, 2023 •

edited

Loading

Jupith commented Mar 3, 2023

Lulalaby commented Mar 3, 2023

Jupith commented Mar 3, 2023

IllagerCaptain commented Mar 3, 2023

Lulalaby commented Mar 3, 2023

Misha-133 commented Mar 4, 2023

Puncher1 commented Mar 9, 2023

Lulalaby commented Mar 9, 2023

advaith1 commented Mar 9, 2023

Puncher1 commented Mar 9, 2023

advaith1 commented Mar 9, 2023

Puncher1 commented Mar 9, 2023

Lulalaby Mar 9, 2023

shaydewael left a comment

	\| guild_id? \| snowflake \| guild associated with the bot. For example a developer support server. \|
	\| guild_id? \| snowflake \| guild associated with the bot, e.g. a developer support server \|

	\| approximate_guild_count? \| integer \| an approximate count of the bots guild membership. \|
	\| approximate_guild_count? \| integer \| an approximate count of the guilds the bot was added to \|


		## Get Current Bot Application Information % GET /applications/@me

		Returns the bot's [application](#DOCS_RESOURCES_APPLICATION/application-object) object.

Adds approx guild count and get self application endpoint #5971

Adds approx guild count and get self application endpoint #5971

Conversation

Jupith commented Mar 2, 2023

splatterxl Mar 2, 2023 • edited Loading

Choose a reason for hiding this comment

splatterxl Mar 2, 2023 • edited Loading

Choose a reason for hiding this comment

ooliver1 Mar 2, 2023

Choose a reason for hiding this comment

Jupith Mar 2, 2023

Choose a reason for hiding this comment

Lulalaby Mar 2, 2023

Choose a reason for hiding this comment

TTtie Mar 2, 2023

Choose a reason for hiding this comment

Lulalaby Mar 2, 2023

Choose a reason for hiding this comment

Misha-133 commented Mar 2, 2023 • edited Loading

Jupith commented Mar 3, 2023

Misha-133 commented Mar 3, 2023 • edited Loading

Jupith commented Mar 3, 2023

Lulalaby commented Mar 3, 2023

Jupith commented Mar 3, 2023

IllagerCaptain commented Mar 3, 2023

Lulalaby commented Mar 3, 2023

Misha-133 commented Mar 4, 2023

Puncher1 commented Mar 9, 2023

Lulalaby commented Mar 9, 2023

advaith1 commented Mar 9, 2023

Puncher1 commented Mar 9, 2023

advaith1 commented Mar 9, 2023

Puncher1 commented Mar 9, 2023

Lulalaby Mar 9, 2023

Choose a reason for hiding this comment

shaydewael left a comment

Choose a reason for hiding this comment

splatterxl Mar 2, 2023 •

edited

Loading

splatterxl Mar 2, 2023 •

edited

Loading

Misha-133 commented Mar 2, 2023 •

edited

Loading

Misha-133 commented Mar 3, 2023 •

edited

Loading