refactor repl commands, add :help command #230
Conversation
| longHelp = "", | ||
| category = Dev, | ||
| cmdtype = ShellCmd, | ||
| action = handleAnn, |
There was a problem hiding this comment.
I no longer see any benefit to separating out the definition of the actions like this. It just means the code for each command is spread out over multiple parts of the file. At the very least I think we should move the definition of each action to right after the definition of its REPLCommand, so all the code for each command will be in one place.
src/Disco/Interactive/Commands.hs
Outdated
| category = Dev, | ||
| cmdtype = ShellCmd, | ||
| action = handleTypeCheck, | ||
| parser = TypeCheck <$> parseTypeTarget |
There was a problem hiding this comment.
Can we also move the definition of parseTypeTarget to right here? Unless I am mistaken this is the only place it is used.
src/Disco/Interactive/Commands.hs
Outdated
| iputStrLn "" | ||
| where | ||
| sortedList cmds = sortBy (\(SomeCmd x) (SomeCmd y) -> compare (name x) (name y)) $ filteredCommands cmds | ||
| -- remove "builtins" (let, eval, etc), don't show dev-only commands by default |
There was a problem hiding this comment.
It would be nice if we could find a good way to show built-in commands too, though I think that can probably be put off to the future.
There was a problem hiding this comment.
@byorgey I added build-in commands to the help output.
bookshelfdave
force-pushed
the
dp_help_command
branch
from
2f11cfd
to
b3329b7
Compare
bookshelfdave
force-pushed
the
dp_help_command
branch
from
11de87a
to
b3329b7
Compare
src/Disco/Interactive/Commands.hs
Outdated
| usingCmd = | ||
| REPLCommand { | ||
| name = "using", | ||
| helpcmd = ":using <extension>", |
There was a problem hiding this comment.
Shouldn't have a colon in front of :using.
There was a problem hiding this comment.
fixed, is using a dev-only command?
There was a problem hiding this comment.
No, using is for end users to turn on language extensions.
| @@ -91,342 +91,321 @@ annCmd :: REPLCommand 'CAnn | |||
| annCmd = | |||
| REPLCommand { | |||
| name = "ann", | |||
| helpcmd = ":ann", | |||
There was a problem hiding this comment.
I like the idea of having a helpcmd field. However, let's not put explicit tab characters in them --- both because we should avoid using tabs in the output (different terminals etc. may display them differently) and also because it's fragile. Instead let's make the code to display the help more general, so it figures out the maximum length of all the helpcmd fields it's being asked to display, and pads things out with spaces approriately.
There was a problem hiding this comment.
agreed on tabs, I'll push another change to this PR soonish.
bookshelfdave
force-pushed
the
dp_help_command
branch
from
8e13e93
to
b3329b7
Compare
bookshelfdave
force-pushed
the
dp_help_command
branch
from
b3329b7
to
f47f9c9
Compare
|
@byorgey removed tabs, padding |
GADT/typed indices implementation from byorgey via #229
bookshelfdave
force-pushed
the
dp_help_command
branch
from
541913c
to
21841a3
Compare
| @@ -0,0 +1,2 @@ | |||
| :help | |||
| 1+1 | |||
There was a problem hiding this comment.
Restyled.io wants to strip the whitespace after the :help command, so I added a simple 1+1 to produce additional output.
|
Looks good to me! |
GADT/typed indices implementation from @byorgey via #229
see also: