Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Japanese characters don't wrap correctly on window title #117

Closed
kerunaru opened this issue Aug 23, 2021 · 6 comments · Fixed by #122
Closed

Japanese characters don't wrap correctly on window title #117

kerunaru opened this issue Aug 23, 2021 · 6 comments · Fixed by #122
Assignees
Labels
enhancement New feature or request

Comments

@kerunaru
Copy link

Here the title is correct, showing the character "C".

Captura de pantalla 2021-08-23 a las 18 32 25

Here is corrupted.

Captura de pantalla 2021-08-23 a las 18 28 41

I recall japanese characters are bigger than ASCII ones… Could it be vtm is splitting the character without considering this?

@o-sdn-o
Copy link
Collaborator

o-sdn-o commented Aug 23, 2021

At this point, vtm wraps text strings cell by cell, so any wide characters are split in half. These are CJK, Emoji and all other wide Unicode characters. The problem will be resolved with the hyphenation module (it is not ready yet). This will allow wrap graphemes (and words) without splitting in half.

@o-sdn-o
Copy link
Collaborator

o-sdn-o commented Aug 23, 2021

Since no terminal is yet able to display halves of wide characters, they are displayed with a placeholder

@o-sdn-o
Copy link
Collaborator

o-sdn-o commented Aug 23, 2021

Related discussion microsoft/terminal#4345

@o-sdn-o o-sdn-o added the enhancement New feature or request label Aug 24, 2021
@o-sdn-o o-sdn-o self-assigned this Aug 24, 2021
@o-sdn-o
Copy link
Collaborator

o-sdn-o commented Aug 24, 2021

image

@o-sdn-o o-sdn-o linked a pull request Oct 30, 2021 that will close this issue
@o-sdn-o
Copy link
Collaborator

o-sdn-o commented Oct 30, 2021

So far, I've only solved this issue with window titles. The built-in terminal still cuts wide characters in half when wrapping.

@o-sdn-o
Copy link
Collaborator

o-sdn-o commented Oct 30, 2021

This functionality is available in v0.5.9999.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants