always call Flush(), to stop the sending routine

dimkr · Sep 4, 2024 · dae3721 · dae3721
1 parent 243fc7c
commit dae3721
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/front/cache.go b/front/cache.go
@@ -62,10 +62,9 @@ func callAndCache(r *request, w text.Writer, args []string, f func(text.Writer,
 	for {
 		chunk, ok := <-c
 		if !ok {
-			if send {
-				if err := w.Flush(); err != nil {
-					r.Log.Warn("Failed to send response", "error", err)
-				}
+			// always call Flush()
+			if err := w.Flush(); err != nil && send {
+				r.Log.Warn("Failed to send response", "error", err)
 			}
 
 			break