Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for Bevy 0.6 #91

Closed
wants to merge 6 commits into from
Closed

Fixes for Bevy 0.6 #91

wants to merge 6 commits into from

Conversation

deontologician
Copy link

@deontologician deontologician commented Jul 28, 2021 •
edited
Loading

Some fixes I had to make to get bevy_rapier to compile against the latest bevy main.

  • AppBuilder has been folded into App
  • App::world() is now just a public field, not a method
  • It's using glam 0.15 instead of 0.13
    • Deprecation warning about from_slice_unaligned

@deontologician deontologician mentioned this pull request Jul 28, 2021
Closed
@deontologician deontologician changed the title Bevy main fixes Fixes for Bevy 0.6 Jul 29, 2021
pcwalton and others added 2 commits October 14, 2021 12:57
@pcwalton @deontologician
Update to Bevy 0.6 main branch.
3214c68 
The biggest change here is that doing the same query twice, one mutably and one
immutably, is no longer needed, once bevyengine/bevy#2305 lands. Before that
lands, however, this upgrade is actually impossible to do safely, since the
`q0`/`q0_mut` distinction is gone and therefore it's impossible to implement
the Rapier component traits on Bevy queries. (This is filed upstream as
bevyengine/bevy#2744.) Therefore, this upgrade has to wait until that Bevy PR
lands.

Other minor changes:

* `Light` has been renamed to `PointLight`.

* `App::build()` is now `App::new()`, and `AppBuilder` is now `App`.

* `glam` has been upgraded upstream.
@deontologician
Add bevy-components feature
20b824c
@deontologician
Copy link
Author

This is now updated with all fixes I know of to get bevy_rapier compiling against bevy/main

It depends on the changes in these two PRs:

plus bevy from this PR:

This is obviously a bit of a mess, so I don't expect it to be merged as-is, but this is working code that with elbow grease gets bevy_rapier working against mainline bevy

@deontologician deontologician mentioned this pull request Oct 18, 2021
Closed
@cart
Copy link

cart commented Dec 1, 2021

As a heads up: I'm planning on merging bevyengine/bevy#2305 tomorrow, which should hopefully unblock the work being done here

@cart
Copy link

cart commented Dec 2, 2021

bevyengine/bevy#2305 is merged!

@cart
Copy link

cart commented Jan 8, 2022

Bevy 0.6 was just released. Can we get this ball rolling again?

@sebcrozet
Copy link
Member

@cart Perfect! Congrats for the release 🎊 I will take a look at this tomorrow.

@sebcrozet
Copy link
Member

sebcrozet commented Jan 9, 2022 •
edited
Loading

Thank you for this PR @deontologician! I will go for the solution based on wrapper types #102. It is less intrusive and sounds more future-proof to me since I will experiment with making more idiomatic components directly into bevy_rapier instead of rapier itself.

@sebcrozet sebcrozet closed this Jan 9, 2022
@deontologician
Copy link
Author

A good call, I tried to get a wrapper solution working but it seemed to be an endless rabbit hole. Glad someone made a working PR for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deontologician @cart @sebcrozet @pcwalton