-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use system-consistent icon sizing. #65
Comments
|
In #63 I added a setting to try and help adjust icons appropriately according to DPI. However, I've never be sure if what I've done is the right approach. It now occurs to me that the choice of icon sizes might be more accurately determined by interrogating the default font size in use. I've had to play similar games in the past. To detect a dark/light theme I create some text in a QLabel and test the relationship between the text and background colors. In this instance could extract a QLabel's font size (in a relevant metric) and base icon sizes around that. |
@digitaltrails, https://www.infobyip.com/detectmonitordpi.php states 96×96 DPI. I use a 1440p monitor. "After" at #63 (comment) is (more like) what I expected. |
In the I think the following code might be returning True:
I'll have to add some logging to see for sure. |
I've not been able to locate it, @digitaltrails. Could you screenshot the window you refer to? |
@digitaltrails, mine is different – that option is absent. |
Oh, it's a new option in v.12.0, you'd need to probably download the vdu_controls.py from github and replace the version you're using - or wait for the distribution to catch up. I thought I'd released in in v1.11, but no v1.12 only got released yesterday. |
Duplicate of #63 - see further info there. |
The current iconography is unnecessarily large:
See https://discuss.kde.org/t/qml-python3-how-to-read-icons-kcm-configured-sizes/1209/7?u=rokejulianlockhart
The text was updated successfully, but these errors were encountered: