-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not launch on Kubuntu 23.04 / Python 3.11 / ddcutil 1.4.1 #60
Comments
Thanks for taking the time to report this. When testing a new install I forgot to delete If you're getting errors related to the sleep-multiplier, they're most likely for a different reason. If the error isn't giving you a stacktrace, you might have to enable debugging and post the log:
Sleep multiplier errors may occur if there is an issue with communicating with a monitor. But they shouldn't cause a crash, so this is quite interesting/disappointing. |
Hello, thanks for the quick response. The fix you pushed worked, now the GUI launches without problems. However, the problem with the settings causing a crash still persists. Here are the logs:
|
This second crash seems to be due to something in the DDC Capabilities description of the monitor that python configparser doesn't like. I've not seen that before, most likely you're the first person to try vdu_controls with this make and model, or the first to bother raising an issue, thanks for taking the time to do so. The I've reproduced the issue by simulating this particular monitors definition. The capabilities text appears to be:
|
I've pushed a change which removes percent signs from the capabilities text. It's probably not the complete/proper solution but I hope it might get you going. It's end of day here, I'll take a harder look at this tomorrow afternoon. |
Looks good, now it does not crash. Thank you. I'll be happy to test further fixes if you would like to. |
Thanks, that confirms the cause of the issue. I've just pushed a permanent fix. It looks like I had encountered similar issues with % in the past, but had just patched around the issue, but had not covered all cases. I found a general solution in the ConfigParser documentation. I've disabled the special treatment of % in the python ConfigParser parser (disabled % interpolation). Hopefully %-signs should no longer be an issue anywhere in the config file values. I don't think you will encounter any issues with this further change, but if you'd like to test it, you can do so by starting without a config file. Everything should load fine, and the % sign will actually be retrieved and saved without issue. I will look to release v1.11.1 as a release later today (after I do a bit more testing). |
Fix released in v1.11.1 |
After downloading and launching the script (I tried both latest release and latest commit on master) an error is shown:
Error: AttributeError: PRESERVE_WINDOW_STATE Is the sleep-multiplier setting too low?
and GUI won't launch.Here is the traceback:
If I comment out the check on the line 7087 which caused the error, the GUI launches just fine. However, if I open settings, same error complaining about sleep-multiplier is shown again and the GUI crashes.
The text was updated successfully, but these errors were encountered: