Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undostack: Fix segfault when trying to fetch macro on -1 index #144

Merged
merged 1 commit into from
Feb 6, 2024

Commits on Feb 5, 2024

  1. Undostack: Fix segfault when trying to fetch macro on -1 index

    Currently, if user adds a command to the undostack, and then undos it,
    and then adds another command - this causes a segfault while fetching
    macro ID from command on current undoPos. Current undo position pointer
    of undostack is being moved to -1 if user undos every possible command
    on the stack. Everytime user adds a new command, eraseRedundantCmds()
    method is being called, because all commands that are in "undo" state
    need to be cleared. So the solution to that is to simply clear every
    single macro and command while erasing redundant commands, if the
    current undo position is -1 - this basically means that every single
    command/macro is in undo state, so we clear all of them.
    tetektoza committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    44f0ee7 View commit details
    Browse the repository at this point in the history