enable passing of external Axes to plot on #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
P.S.: "we" here is me and @cwmeijer :) |
egpbos
force-pushed
the
external_Axes_passing
branch
from
6535e5a
to
3607930
Compare
|
Whoops, forgot to rebase on main, done now. |
stefsmeets
approved these changes
Jun 18, 2024
|
Your nitpick is my command ;) I did not hint it completely. The matplotlib stuff is just too complex and bloaty and increases maintenance cost. I think the reference in the docstring to go look at mpl.Axes.imshow is best for those options. |
|
The CI failures are HTTP timeouts unrelated to this PR. |
cwmeijer
reviewed
Jun 19, 2024
cwmeijer
reviewed
Jun 19, 2024
cwmeijer
approved these changes
Jun 19, 2024
|
Will you merge when you think it's done? |
Adds to the plot_image and plot_tabular functions an optional argument ax: plt.Axes. When given, this is the Axes that will be used to plot on and the internal plt.subplots call is skipped. This is useful for using these functions in custom multi-panel plots (we want to use this in a paper).
egpbos
force-pushed
the
external_Axes_passing
branch
from
37483d9
to
4052032
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds to the plot_image and plot_tabular functions an optional argument ax: plt.Axes. When given, this is the Axes that will be used to plot on and the internal plt.subplots call is skipped. This is useful for using these functions in custom multi-panel plots (we want to use this in a paper).
We actually only need this for the
plot_imagefunction, but I added it toplot_tabularas a bonus ;) Theplot_timeseriesfunction is too complicated, I don't have time to add it there right now, but the principle will be similar (except now the ax has to be passed through three layers of helper functions).