Automatic data downloading with pooch #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
loostrum
added
the
standup
Move downloader to utils Add more files to downloader
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
loostrum
removed
the
standup
cwmeijer
approved these changes
Jun 19, 2024
tests/test_downloader.py
Outdated
There was a problem hiding this comment.
Nice and thorough! This is quite a heavy test. Could we run this for only one build config for instance instead of all build configurations?
| data_cmap=None, | ||
| show_plot=True, | ||
| output_filename=None): | ||
| def plot_image( |
There was a problem hiding this comment.
why this reformatting? just some autoformatter I suppose? it makes the pr a bit larger.
Run downloader test in CI only in single build
|
@loostrum if all models are downloaded from Zenood now, why to keep the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A downloader utility was added, which contains an overview of all data files we use, hosted on either Github or Zenodo.
With the
dianna.utils.downloader.downloadfunction, one can download and use any of these files. The files are downloaded to an OS cache directory by default, and the checksums are verified so any changes in the online files are detected.The tutorials were updated to use this functionality.
While rerunning the notebooks I noticed the colormaps were mostly wrong (default viridis instead of bwr). This is due to #776, where the colormaps were removed from the notebooks, but the defaults were not set in the dianna code for all modalities (only in the dashboard it seems). In this PR I added the bwr default to the visualization module where not already present.