-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
783 simplify overview tutorial #792
Conversation
…ble from zenodo. Fixed colormaps where there is not default in our code
Fixed the link to the overview tutorial!
…l sections, referral to all tutorials, adding some links and logos, some formatting.
…/dianna into 783-simplify-overview-tutorial
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
The ONNX model for the binary MNIST used in the tutorial is not the one from Zenodo! Some TF variant that is not on Zenodo is used, Using the one in Zenodo gives an error. So, the notebook still depends on local models and some other locally stored data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elboyran thanks, looks very good 👍 I was able to run the notebook. One minor comment: is there a reason why we don't plot the results of kernelshap, the last method in the notebook?
@SarahAlidoost thanks for reviewing! If you recall during the last stand-up (or maybe you were not there?) there was the opinion that I should skip the whole Explainers section as it was redundant. Still, I opted for keeping it and gradually "simplifying" it, which includes firstly elaborating on LIME (corresponding to a missing LIME for Binary MNIST tutorial), then less for the second explainer, and finally not showing the last visualization. The point of the section for me is:
I hope this PR achieves that. |
Make the overview tutorial better.