Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MANIFEST.in #778

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Update MANIFEST.in #778

merged 1 commit into from
Jun 5, 2024

Conversation

elboyran
Copy link
Contributor

@elboyran elboyran commented May 31, 2024

With the current installation, the code reorganization was not reflected in the installation.
Now all the data, labels, and models folders have been included explicitly.

@elboyran elboyran self-assigned this May 31, 2024
@elboyran elboyran added bug Something isn't working blocking labels May 31, 2024
@elboyran elboyran marked this pull request as ready for review May 31, 2024 08:18
@elboyran elboyran moved this from In progress to Ready for review in SS Sprint 8 - EO & EULAW usecases; big fixes and outreach May 31, 2024
Copy link
Member

@loostrum loostrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future I would recommend that we try the Zenodo download option for everything, so we don't have to include these files in the install at all. But for now, it is important that we fix the notebooks and the changes look good, so let's merge it!

@elboyran
Copy link
Contributor Author

elboyran commented Jun 5, 2024

In the future I would recommend that we try the Zenodo download option for everything, so we don't have to include these files in the install at all. But for now, it is important that we fix the notebooks and the changes look good, so let's merge it!

Indeed, I made even an issue about it some time ago. #171

@elboyran elboyran merged commit 8a9aa0c into main Jun 5, 2024
34 of 36 checks passed
SS Sprint 8 - EO & EULAW usecases; big fixes and outreach automation moved this from Ready for review to Done Jun 5, 2024
@elboyran elboyran deleted the installation-patch branch June 14, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocking bug Something isn't working
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants