Run text model inputs one-by-one through model to avoid shape mismatch errors #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
elboyran
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a difference between the movie review model runner used in the RISE text tutorial, vs LIME text, the tests and the dashboard. The LIME/dashboard/tests version first tokenizes all inputs, then runs the model once. The RISE version runs sentences through the model one-by-one. The latter is slower, but avoids the issues we've been seeing with special chars. The faster version could work if one makes sure the inputs all have the same shape, but this can be complicated so I suggest we go with the slower, but correct, version.
Fixes #531
Fixes #771
Fixes #751