Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data file paths for Colab #772

Merged
merged 5 commits into from
May 29, 2024
Merged

Fix data file paths for Colab #772

merged 5 commits into from
May 29, 2024

Conversation

loostrum
Copy link
Member

Use files from dianna installation folder in all tutorials.

This simplifies the colab setup as we no longer need to download data
files.

The relative paths throughout the tutorials were replaced by paths
starting from the dianna install dir, which should work on all
platforms.

The indentation in the colab setup was also fixed, this was 2 spaces
instead of 4 in many places.

Fixes #750

This simplifies the colab setup as we no longer need to download data
files.
The relative paths throughout the tutorials were replaced by paths
starting from the dianna install dir, which should work on all
platforms.
The indentation in the colab setup was also fixed, this was 2 spaces
instead of 4 in many places.
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@loostrum loostrum requested a review from elboyran May 29, 2024 08:46
Copy link
Contributor

@elboyran elboyran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nice work, thanks!
Will do the same in the new (renamed demo) overview tutorial in my PR #769 .

@elboyran elboyran mentioned this pull request May 29, 2024
12 tasks
@loostrum loostrum merged commit 79f4b87 into main May 29, 2024
17 checks passed
@loostrum loostrum deleted the 750-fix-colab-paths branch May 29, 2024 09:06
@elboyran
Copy link
Contributor

elboyran commented May 30, 2024

Sorry @loostrum , I have noticed only now that the root_dir was introduced, but not used in the Kernelshap weather regression tutorial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

text vector file not found in lime_text on colab
2 participants