Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update READMEs with KernalSHAP mark and links #745

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Update READMEs with KernalSHAP mark and links #745

merged 2 commits into from
Apr 10, 2024

Conversation

elboyran
Copy link
Contributor

@elboyran elboyran commented Apr 10, 2024 •
edited
Loading

Updated Tutorials section of main and the Tutorials README including the KernaSHAP tutorials on tabular data.

Solves #739

@elboyran elboyran requested a review from cwmeijer April 10, 2024 11:40
@elboyran elboyran self-assigned this Apr 10, 2024
@elboyran elboyran marked this pull request as ready for review April 10, 2024 11:52
@elboyran elboyran linked an issue Apr 10, 2024 that may be closed by this pull request
Kernel SHAP tabular tutorial exampels are missing from the READMEs #739
Closed
2 tasks
@elboyran elboyran added the documentation Improvements or additions to documentation label Apr 10, 2024
cwmeijer
cwmeijer previously approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@cwmeijer cwmeijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cwmeijer
Copy link
Contributor

Not sure why the notebooks are still failing here. Let's not merge it for now.

@cwmeijer cwmeijer dismissed their stale review April 10, 2024 14:24

notebooks are failing for some reason

cwmeijer
cwmeijer approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@cwmeijer cwmeijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why the notebooks are failing on this branch but as it's just a couple of md changes It can't be the reason. Looks good btw!

@cwmeijer cwmeijer merged commit f62a62b into main Apr 10, 2024
23 of 27 checks passed
@elboyran elboyran deleted the KernalSHAP-tutorials-marks branch May 22, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwmeijer cwmeijer cwmeijer approved these changes

Assignees

@elboyran elboyran

Labels
documentation Improvements or additions to documentation
Projects
No open projects
SS Sprint 7 - Have at least 10 issues...
Awaiting triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kernel SHAP tabular tutorial exampels are missing from the READMEs
2 participants
@elboyran @cwmeijer