Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a link to the time series masking blog post from docstrings #744

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

cwmeijer
Copy link
Contributor

@cwmeijer cwmeijer commented Apr 9, 2024

Document the masking strategy by linking to the blog post I wrote about it.
Fixes #564 .
Note that the first commit are the actual planned changes. But I also changed a function name there to make it a bit more clear, which wasn't supposed to be part of this PR, but broke some imports. The second commit is fixing those imports.

@cwmeijer cwmeijer marked this pull request as draft April 10, 2024 14:15
@cwmeijer cwmeijer marked this pull request as ready for review April 15, 2024 07:35
@elboyran elboyran self-requested a review April 15, 2024 12:14
Copy link
Contributor

@elboyran elboyran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Looks neat and link to the blog post.

@elboyran elboyran merged commit 7d9e813 into main Apr 17, 2024
27 checks passed
@elboyran elboyran deleted the 564-time-series-masking-documentation branch June 14, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation/docstrings/examples of strategic masking based on wave function
2 participants