fix macos + 3.11 build #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://github.com/dianna-ai/dianna/actions/runs/8250917332/job/22566702492#step:4:622 All builds [3.9,3.11]X[win, ubuntu,mac] pass except (mac,3.9). I think it's because it is using a new tf version 2.16 where the others are using 2.15. I also replicated this behavior locally but couldn't completely pinpoint the cause. It may also have something to do with the tensorflow-probability version.
See https://github.com/dianna-ai/dianna/actions/runs/8250917332/job/22566702492#step:4:622 All builds [3.9,3.11]X[win, ubuntu,mac] pass except (mac,3.9). I think it's because it is using a new tf version 2.16 where the others are using 2.15. I also replicated this behavior locally but couldn't completely pinpoint the cause. It may also have something to do with the tensorflow-probability version. Fixing tf-prob version <2.24
See https://github.com/dianna-ai/dianna/actions/runs/8250917332/job/22566702492#step:4:622 All builds [3.9,3.11]X[win, ubuntu,mac] pass except (mac,3.9). I think it's because it is using a new tf version 2.16 where the others are using 2.15. I also replicated this behavior locally but couldn't completely pinpoint the cause. It may also have something to do with the tensorflow-probability version. Fixing tf-prob version <2.24
loostrum
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/dianna-ai/dianna/actions/runs/8250917332/job/22566702492#step:4:622 All builds [3.9,3.11]X[win, ubuntu,mac] pass except (mac,3.9). I think it's because it is using a new tf version 2.16 where the others are using 2.15. I also replicated this behavior locally but couldn't completely pinpoint the cause. It may also have something to do with the tensorflow-probability version.
I put another constraint on the tf version that will hopefully solve this for now.