-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify outputs types #703
Unify outputs types #703
Conversation
Co-authored-by: Christiaan Meijer <c.meijer@esciencecenter.nl>
Thanks for reviewing. I addressed your comment about typing. Regarding the notebook error, as discussed, they will be fixed in a separate PR, see #711 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR! Great addition to our code base and improvement in usability!
I made some suggestions, but all are to some extend details. Whether you change anything or not, I approve merging this PR.
🎖
Some checks should pass before we merge. |
Do you mean the failed checks for running the notebooks? For those checks to be passed, the notebooks should be updated. We decided not to update them in this pull request as it makes the PR large. Please see issue #711. Please let me know if there is another check you want me to fix in this PR. |
Yes, you are correct. |
…ning the shap_values_list variable
Thank you for reviewing and nice comments 👍 |
When do we merge this PR? Old and proposed folder structure of
|
closes #640
relates #691, #713, #711
See an overview of changes here.