Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #681

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Update README.md #681

merged 2 commits into from
Jan 10, 2024

Conversation

elboyran
Copy link
Contributor

@elboyran elboyran commented Dec 15, 2023

Solves #679

Solves issue #679
@elboyran elboyran marked this pull request as ready for review December 15, 2023 11:15
Copy link
Member

@geek-yang geek-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating it! Looks great!

@cpranav93
Copy link
Contributor

One suggestion:

  • To be consistent with other entries in the table, it might good to add a line between the two models as done for time-series.

Otherwise looks great and the links work.

@cpranav93
Copy link
Contributor

image

Although looking at the code, it seems like the line should be there and it may be a rendering issue on my web browser, so please ignore it if that's the case

@elboyran
Copy link
Contributor Author

elboyran commented Jan 10, 2024

Although looking at the code, it seems like the line should be there and it may be a rendering issue on my web browser, so please ignore it if that's the case

Thanks, you are fast! I was looking at the wrong README- my both PRs were called "Update README" ;-)

@elboyran
Copy link
Contributor Author

elboyran commented Jan 10, 2024

image

Although looking at the code, it seems like the line should be there and it may be a rendering issue on my web browser, so please ignore it if that's the case

Hmmm, in my branch there is already a line:
image
image

I think I'll merge and see what happens.

@elboyran elboyran merged commit 8b48a6e into main Jan 10, 2024
27 checks passed
@geek-yang geek-yang deleted the elboyran-679-update-tutorials-readme branch January 11, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants