Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

662 Visualization module tabular #680

Merged
merged 7 commits into from
Jan 10, 2024
Merged

662 Visualization module tabular #680

merged 7 commits into from
Jan 10, 2024

Conversation

geek-yang
Copy link
Member

Add visualization module for tabular data.

@geek-yang geek-yang linked an issue Dec 15, 2023 that may be closed by this pull request
@geek-yang geek-yang changed the title Visualization module tabular 662 Visualization module tabular Dec 15, 2023
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@geek-yang geek-yang marked this pull request as ready for review January 5, 2024 15:47
Copy link
Contributor

@cwmeijer cwmeijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! No surprises, which is always great! Thanks a lot!
I made some comments, mostly concerning type hints or doc strings.

dianna/visualization/tabular.py Outdated Show resolved Hide resolved
dianna/visualization/tabular.py Outdated Show resolved Hide resolved
dianna/visualization/tabular.py Show resolved Hide resolved
dianna/visualization/tabular.py Outdated Show resolved Hide resolved
dianna/visualization/tabular.py Outdated Show resolved Hide resolved
Yang and others added 2 commits January 10, 2024 12:52
Co-authored-by: Christiaan Meijer <c.meijer@esciencecenter.nl>
Copy link
Contributor

@cwmeijer cwmeijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@geek-yang geek-yang merged commit cac13ed into main Jan 10, 2024
17 checks passed
@geek-yang geek-yang deleted the visualization_tabular branch January 10, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add visualization module for dianna tabular data methods
2 participants