Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

664 Fix notebooks for CD/CI #675

Merged
merged 4 commits into from
Dec 13, 2023
Merged

664 Fix notebooks for CD/CI #675

merged 4 commits into from
Dec 13, 2023

Conversation

geek-yang
Copy link
Member

@geek-yang geek-yang commented Dec 12, 2023

Fix the notebooks in CD/CI.

Also update the target testing version of python to be py310, as py39 is a bit older now.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@geek-yang
Copy link
Member Author

Ok. I think I find the solution. It is again due to some versions conflicts, this time about onnx. Check this post/issue.

We need to use onnx < 1.15.0.

@geek-yang geek-yang linked an issue Dec 13, 2023 that may be closed by this pull request
Copy link
Contributor

@cpranav93 cpranav93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working indeed! Good find!

@geek-yang geek-yang merged commit be4aa54 into main Dec 13, 2023
17 checks passed
@geek-yang geek-yang deleted the fix_notebooks branch December 13, 2023 12:00
@cwmeijer cwmeijer mentioned this pull request Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tutorials are failing in github action
2 participants