Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

645 Implement SHAP for tabular data #674

Merged
merged 10 commits into from
Jan 11, 2024
Merged

645 Implement SHAP for tabular data #674

merged 10 commits into from
Jan 11, 2024

Conversation

geek-yang
Copy link
Member

@geek-yang geek-yang commented Dec 12, 2023 •
edited
Loading

Add SHAP tabular to the methods and provide example notebooks for both regression and classification tasks:

  • Add SHAP tabular to methods
  • Adapt SHAP to the dianna API
  • Example notebook for classification
  • Example notebook for regression
  • Add tests

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@geek-yang geek-yang linked an issue Dec 12, 2023 that may be closed by this pull request
Investigate SHAP for tabular data #645
Closed
@geek-yang geek-yang marked this pull request as ready for review December 12, 2023 13:08
cwmeijer
cwmeijer reviewed Dec 13, 2023
View reviewed changes
Copy link
Contributor

@cwmeijer cwmeijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I still need to check the notebooks.

tests/methods/test_shap_tabular.py Outdated Show resolved Hide resolved
tests/methods/test_shap_tabular.py Outdated Show resolved Hide resolved
cwmeijer
cwmeijer reviewed Jan 11, 2024
View reviewed changes
tutorials/kernelshap_tabular_penguin.ipynb Show resolved Hide resolved
tutorials/kernelshap_tabular_penguin.ipynb Show resolved Hide resolved
tutorials/kernelshap_tabular_penguin.ipynb Show resolved Hide resolved
tutorials/kernelshap_tabular_penguin.ipynb Show resolved Hide resolved
tutorials/kernelshap_tabular_penguin.ipynb Show resolved Hide resolved
tutorials/kernelshap_tabular_weather.ipynb Show resolved Hide resolved
tutorials/kernelshap_tabular_weather.ipynb Show resolved Hide resolved
tutorials/kernelshap_tabular_weather.ipynb Show resolved Hide resolved
tutorials/lime_tabular_penguin.ipynb Outdated Show resolved Hide resolved
tutorials/lime_tabular_weather.ipynb Outdated Show resolved Hide resolved
cwmeijer
cwmeijer approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@cwmeijer cwmeijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏅

@geek-yang geek-yang merged commit 1fb3a2a into main Jan 11, 2024
17 checks passed
@geek-yang geek-yang deleted the shap_tabular branch January 11, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwmeijer cwmeijer cwmeijer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate SHAP for tabular data
2 participants
@geek-yang @cwmeijer