Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split methods into image, text, timeseries #654

Merged
merged 5 commits into from
Oct 31, 2023
Merged

Split methods into image, text, timeseries #654

merged 5 commits into from
Oct 31, 2023

Conversation

geek-yang
Copy link
Member

Split methods into image, text, timeseries, and the methods will include:

  • lime_image
  • lime_text
  • lime_timeseries
  • rise_image
  • rise_text
  • rise_timeseries
  • kernelshap_image

This PR closes #544 and closes #543 .

@geek-yang geek-yang marked this pull request as ready for review October 27, 2023 09:10
cwmeijer
cwmeijer requested changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@cwmeijer cwmeijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Big PR so I check lots of things but too much to go through everything in detail.
Big improvement for our code. Thanks a lot!

dianna/__init__.py Outdated Show resolved Hide resolved
dianna/utils/predict.py Outdated Show resolved Hide resolved
tests/test_kernelshap.py Show resolved Hide resolved
dianna/methods/rise_text.py Show resolved Hide resolved
dianna/__init__.py Outdated Show resolved Hide resolved
@cwmeijer cwmeijer moved this from To do to Ready for review in SS Sprint 2 - Pay off our technical debt Oct 30, 2023
@geek-yang geek-yang mentioned this pull request Oct 30, 2023
Open
cwmeijer
cwmeijer approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@cwmeijer cwmeijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Merge it please! 🎈

@geek-yang geek-yang merged commit 0f62ec0 into main Oct 31, 2023
18 checks passed
@geek-yang geek-yang deleted the split_all_methods branch October 31, 2023 14:38
@geek-yang geek-yang moved this from Ready for review to Done in SS Sprint 2 - Pay off our technical debt Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwmeijer cwmeijer cwmeijer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
SS Sprint 2 - Pay off our technical debt
Done
SS Sprint 2 - Pay off our technical debt
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

split RISE methods into timeseries, image, text split LIME methods into timeseries, image, text
2 participants
@geek-yang @cwmeijer