Fix CD/CI notebooks

[geek-yang]

Fix notebooks and build for CI/CD.

This PR closes #648 .

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[elboyran]

Some checks did not pass. This time dashboard and build for 3.11.

[geek-yang]

Some checks did not pass. This time dashboard and build for 3.11.

Hi @elboyran , thanks for your quick comment. This is not ready for review. Because of our settings in cd/ci, some tests only run when the PR is switched from draft to ready for review, that's why. Sorry for the confusion.

Anyway, I manage to fix all the builds and notebooks ci, but now dashboard fails 😓. I will try to fix it.

[geek-yang]

Hi @elboyran @cwmeijer , I manage to fix tests for the notebooks and this PR is ready for review now!

[geek-yang]

When fixing the CI for notebooks, the build for python 3.11 on macos fails unexpectedly. Error message indicates that pytest is not found. I figured out that it was due to the installation, in which pytest was installed for python 3 but the ci calls pytest from python via system path. Therefore, it can be fixed by simply change run: pytest -v to run: python3 -m pytest -v.

However, this build will fail again if the caching of package installation is used (not sure why...). By removing the cache, it works nicely. But this makes the CD/CI slower than before. If anyone has better solution, please let me know. Thanks.

[elboyran]

No other solution from me.

[elboyran]

Thanks for fixing it, even if it's slower now.

[elboyran]

No other solution from me.

[cwmeijer]

Some interesting things are happening here. I tried changing some things to more expected variations but I couldn't make them pass the builds. Great that you found a setup that indeed does all tests. Merge it!

[geek-yang]

Thanks for fixing it, even if it's slower now.

No worry. Thanks a lot for your review. I think it is quite tricky....Patrick and Chris also tried hard but still couldn't find a better solution. Let's just keep it like this then.

[geek-yang]

Some interesting things are happening here. I tried changing some things to more expected variations but I couldn't make them pass the builds. Great that you found a setup that indeed does all tests. Merge it!

😅 It took me quite a while to find a solution. Tbh, I'm also not entirely sure about the cause of the failure. But they can be fixed this way. Thanks a lot for the review!