Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 3.11 support #624

Merged
merged 2 commits into from
Aug 3, 2023
Merged

add 3.11 support #624

merged 2 commits into from
Aug 3, 2023

Conversation

cwmeijer
Copy link
Contributor

@cwmeijer cwmeijer commented Jul 12, 2023

This PR Fixes #623.

Why all the red crosses then?

@cwmeijer cwmeijer marked this pull request as ready for review July 20, 2023 08:54
Copy link
Member

@geek-yang geek-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @cwmeijer. Also a few places need to be updated:

I will approve it. But please update the codes above as well. Thanks.

@cwmeijer
Copy link
Contributor Author

cwmeijer commented Aug 3, 2023

@geek-yang , I updated as you suggested and also optimized our build config matrix. Do you agree with those changes as well?
Also see NLeSC/python-template#345.
Basically I only run the oldest and newest supported python versions. It's very unlikely that a single intermediate version would be broken.

@cwmeijer cwmeijer merged commit 5fbeae1 into main Aug 3, 2023
15 of 18 checks passed
@cwmeijer cwmeijer deleted the 623-add-311-support branch August 3, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix failing conversion notebooks add 3.11 support
2 participants