Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude coverage check for dashboard #616

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Exclude coverage check for dashboard #616

merged 1 commit into from
Jun 7, 2023

Conversation

geek-yang
Copy link
Member

dashboard is checked but since it is checked within subprocess it is not detected by sonarcloud coverage. This produces misleading results. So it is better to exclude the coverage check for dashboard from the report.

@geek-yang geek-yang marked this pull request as ready for review June 6, 2023 13:25
@geek-yang geek-yang requested a review from stefsmeets June 6, 2023 13:32
stefsmeets
stefsmeets approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@stefsmeets stefsmeets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super!

@stefsmeets stefsmeets merged commit 824a236 into main Jun 7, 2023
32 checks passed
@stefsmeets stefsmeets deleted the exclude_dashboard_coverage branch June 7, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefsmeets stefsmeets stefsmeets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@geek-yang @stefsmeets