Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upped scikit-image and some naming changes #614

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Conversation

WillemSpek
Copy link
Collaborator

see #613 it's just some very minor changes that should enhance compatibility and not impede functionality. Should be a quick review :)

@WillemSpek WillemSpek self-assigned this Jun 1, 2023
Copy link
Contributor

@stefsmeets stefsmeets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What exactly does this fix?

@WillemSpek
Copy link
Collaborator Author

WillemSpek commented Jun 1, 2023

Thanks for the review!

  1. Dependency conflict

ERROR: Cannot install -r requirements.in (line 3) and -r requirements.in (line 7) because these package versions have conflicting dependencies.

The conflict is caused by:
dianna 0.9.0 depends on scikit-image==0.19.1
quantus 0.4.0 depends on scikit-image>=0.19.3

  1. problem with Quantus and DIANNA integration:

TypeError: explain() got multiple values for argument 'model'

Basically because quantus also uses model to pass on to the explain function which collides with the required positional argument model from DIANNA in kernelshap.explain. On top of that, model_or_function appears to be consistent with the naming for the other methods.

@WillemSpek WillemSpek merged commit ecc9b51 into main Jun 1, 2023
22 checks passed
@WillemSpek WillemSpek linked an issue Jun 1, 2023 that may be closed by this pull request
@stefsmeets
Copy link
Contributor

Thanks for the explanation, makes sense 👍

@stefsmeets stefsmeets deleted the 613-FixCompatibility branch June 1, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatibility issues
2 participants