Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

559 address duplication predict function #610

Merged
merged 7 commits into from
Jun 1, 2023
Merged

559 address duplication predict function #610

merged 7 commits into from
Jun 1, 2023

Conversation

geek-yang
Copy link
Member

@geek-yang geek-yang commented May 31, 2023 •
edited
Loading

In this PR we refactor lime_timeseries, rise_timeseries and rise to remove the duplicated prediction function in the code.

Also includes some minor refactoring changes.

Fixes #559.

@geek-yang geek-yang linked an issue May 31, 2023 that may be closed by this pull request
Merge duplication code in LIME and RISE for timeseries #559
Closed
@geek-yang geek-yang marked this pull request as ready for review June 1, 2023 08:35
@geek-yang geek-yang requested a review from stefsmeets June 1, 2023 08:48
stefsmeets
stefsmeets approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@stefsmeets stefsmeets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, looks good to me! All tests are passing, and no complaints here either! 🚀

@geek-yang
Copy link
Member Author

Cool, looks good to me! All tests are passing, and no complaints here either! 🚀

Thanks a lot @stefsmeets for your light-speed review 😎. I will merge it then.

@geek-yang geek-yang merged commit dd020d2 into main Jun 1, 2023
32 checks passed
@geek-yang geek-yang deleted the 559-address-duplication-predict-function branch June 1, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefsmeets stefsmeets stefsmeets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merge duplication code in LIME and RISE for timeseries
2 participants
@geek-yang @stefsmeets