Improve test suite time by 25% #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before 31 s, After 1 s
geek-yang
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I noticed that some of the tests are quite slow. I had a quick look and noticed the RISE image pipeline test can be made about 20 times faster by reducing the shape of the image:
Before:
28.10s call tests/test_common_usage.py::test_common_RISE_image_pipelineAfter:
1.74s call tests/test_common_usage.py::test_common_RISE_image_pipelineSince we are testing the pipeline only, the size of the image is irrelevant (it's filled with random data anyway). This takes the time needed to run the tests down from 0:01:59 to 0:01:31 on my setup.