Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid pip install in workflow if cache is hit #592

Merged
merged 6 commits into from
May 30, 2023
Merged

Avoid pip install in workflow if cache is hit #592

merged 6 commits into from
May 30, 2023

Conversation

stefsmeets
Copy link
Contributor

@stefsmeets stefsmeets commented May 15, 2023 •
edited
Loading

This PR skips the pip install step if the cache is restored. This saves a couple of minutes on every workflow run.

Saves:

  • Windows: ~3 min
  • Ubuntu: ~1 min
  • Mac: ~3 min

@stefsmeets stefsmeets marked this pull request as ready for review May 15, 2023 09:11
@stefsmeets stefsmeets marked this pull request as draft May 15, 2023 09:32
@stefsmeets stefsmeets marked this pull request as ready for review May 15, 2023 09:39
@elboyran elboyran self-requested a review May 22, 2023 13:30
elboyran
elboyran approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@elboyran elboyran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, thanks!

@stefsmeets stefsmeets merged commit d3b0aef into main May 30, 2023
@stefsmeets stefsmeets deleted the ga-action branch May 30, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elboyran elboyran elboyran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stefsmeets @elboyran