Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for python 3.7 #588

Merged
merged 1 commit into from
May 15, 2023
Merged

Drop support for python 3.7 #588

merged 1 commit into from
May 15, 2023

Conversation

stefsmeets
Copy link
Contributor

This PR drops support for Python 3.7.

Closes #587

Cool new python features we get from supporting 3.8 and up:

  • Walrus operator
  • = specifier in f-strings

@stefsmeets stefsmeets marked this pull request as ready for review May 10, 2023 14:46
@stefsmeets stefsmeets requested a review from geek-yang May 11, 2023 12:51
geek-yang
geek-yang approved these changes May 12, 2023
View reviewed changes
Copy link
Member

@geek-yang geek-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. I think that's it for everywhere with python 3.7. Let's get it merged!

@stefsmeets stefsmeets merged commit 4205fe7 into main May 15, 2023
@stefsmeets stefsmeets deleted the drop-37 branch May 15, 2023 07:18
@stefsmeets stefsmeets mentioned this pull request Jun 5, 2023
Merged
@egpbos egpbos mentioned this pull request Jul 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geek-yang geek-yang geek-yang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop support for Python 3.7
2 participants
@stefsmeets @geek-yang