Fix the special character problem #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefsmeets
changed the title
|
Hi @laurasootes Can you have a look at this PR and let me know what you think? The Ubuntu/Python3.7 build is failing because of #587 |
|
Hi @laurasootes did you have any time to look at this? Should we ask someone else to do the review? |
laurasootes
approved these changes
May 30, 2023
|
[heart] Elena Ranguelova reacted to your message:
…________________________________
From: Laura ***@***.***>
Sent: Tuesday, May 30, 2023 3:01:37 PM
To: dianna-ai/dianna ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [dianna-ai/dianna] Fix the special character problem (PR #585)
@laurasootes approved this pull request.
Nice! Very clean fix.
I was still able to find some combination that would break the code, but that could not really be considered a sentence. The sentences that I found earlier do now all work.
—
Reply to this email directly, view it on GitHub<#585 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAYYBWPV6EALTCMETAILYHLXIYDVDANCNFSM6AAAAAAX3JT7UA>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix the 'special character problem'.
I have identified this as a failing string:
Hello, to the world!Oddly enough, this works:
Hello, world!I updated the fix in
SpacyTokenizerto fix the sentence before sending it to the spacy tokenizer instead of trying to make sence of the tokens after tokenization. The new fix will add spaces around all instances of UNKWORDZ where missing using regexes. And hopefully, it's a bit more future-proof when we come accros new issues.The implementation differs slightly in that this does not consider multiple special characters as a single token. This is inline with the tokenization expected from spacy.
I found the error message very confusing, so I also added a check to make sure that the number of tokens is consistent for all sentences.
I also updated the tests to specifically test the tokenizer, rather than the full explain text pipeline.
Todo