Add dashboard to package on pypi #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @cwmeijer , could you you have a look at this and let me know if you have any feedback? (Ignore the sonarcloud warnings, they are for the timeseries page that is unfinished) |
cpranav93
approved these changes
May 3, 2023
There was a problem hiding this comment.
It looks really great! it's quite amazing to see the dashboard transform as it has in a short while. Great work @stefsmeets!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the dashboard as package data so that it can be distributed via pypi. When users run
pip install dianna[dashboard], they will have everything they need to start the dashboard on the command line viadianna-dashboard.The dashboard can be found under
dianna/dashboardand the data files underdianna/data(see this link for more info).Closes #356