Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

557 fix first instance issue for Lime timeseries #578

Merged
merged 2 commits into from
May 2, 2023

Conversation

geek-yang
Copy link
Member

@geek-yang geek-yang commented May 1, 2023

Fix #557.

Now it ensures the first instance is the original data, which satisfies the requirement from https://github.com/marcotcr/lime/blob/fd7eb2e6f760619c29fca0187c07b82157601b32/lime/lime_base.py#L148-L149

@geek-yang geek-yang changed the title 557-fix first instance issue for Lime timeseries 557 fix first instance issue for Lime timeseries May 1, 2023
@geek-yang geek-yang marked this pull request as ready for review May 1, 2023 16:14
@geek-yang geek-yang requested a review from cpranav93 May 1, 2023 16:14
Copy link
Contributor

@cpranav93 cpranav93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great! One point of modularity, it might be better to have the "masks[0,:,:] = 1.0" as a flagged option in maskers.py rather than in lime. But we can also do that later once Chris is finished with the masks.

@geek-yang
Copy link
Member Author

It looks great! One point of modularity, it might be better to have the "masks[0,:,:] = 1.0" as a flagged option in maskers.py rather than in lime. But we can also do that later once Chris is finished with the masks.

Good suggestion! I mark it in issue #556. When Chris finished the segmentation, we can implement it. Thanks for your review @cpranav93 😄.

@geek-yang geek-yang merged commit e198621 into main May 2, 2023
@geek-yang geek-yang deleted the 557-fix-first-instance-for-LIME branch May 2, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix first instance issue in LIME timeseries implementation
2 participants