Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

574 README taxonomy #576

Merged
merged 5 commits into from
Apr 28, 2023
Merged

574 README taxonomy #576

merged 5 commits into from
Apr 28, 2023

Conversation

WillemSpek
Copy link
Collaborator

Updated the taxonomy according to the recent advancement for time-series. Additionally, DIANNA does not (yet) have global explanations, therefore these are now excluded in the taxonomy.

I used the figure from here: https://www.semanticscholar.org/paper/Classification-of-Explainable-Artificial-Methods-Vilone-Longo/47270bad365ad9c4c4b13c9f56fa384e5160c072 Given that we already used this image, I assumed there were no copyright issues.

Copy link
Contributor

@cwmeijer cwmeijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Much better!
I think our output type actually is both visual and numerical. The latter is still missing in the figure but that can also be fixed some other time.
Merge it :-)

Copy link
Member

@geek-yang geek-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The markdown check is failing because one dead link. It doesn't relate to this PR but maybe it is better to fix it here.

The dead link is related to pytorch lightning, it should be "https://lightning.ai/docs/pytorch/latest/api/lightning.pytorch.core.LightningModule.html#lightning.pytorch.core.LightningModule" now.

@WillemSpek sorry for the small hassle 😜. And now all the checks are green 👍.

@WillemSpek
Copy link
Collaborator Author

Thanks for the linter fix @geek-yang! Will merge now

@WillemSpek WillemSpek merged commit b05e69c into main Apr 28, 2023
@geek-yang geek-yang deleted the 574-READMETaxonomy branch April 28, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants