Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing workflows #563

Merged
merged 3 commits into from
Apr 19, 2023
Merged

Fix failing workflows #563

merged 3 commits into from
Apr 19, 2023

Conversation

stefsmeets
Copy link
Contributor

@stefsmeets stefsmeets commented Apr 18, 2023

I noticed two workflows are failing on the main branch:

Invalid workflow file: .github/workflows/fair-software.yml#L33
The workflow is not valid. .github/workflows/fair-software.yml (Line: 33, Col: 9): Unexpected symbol: 'and'. Located at position 39 within expression: (github.event_name == 'pull_request') and (github.event.pull_request.draft == false)
Invalid workflow file: .github/workflows/documentation.yml#L28
The workflow is not valid. .github/workflows/documentation.yml (Line: 28, Col: 9): Unexpected value 'extras-require'

This PR fixes these.

Copy link
Member

@cwmeijer cwmeijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I quickly looked up the syntax corrections. This looks conform the manual now (https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepswith). Great job! Thanks!

@stefsmeets stefsmeets merged commit 24602a3 into main Apr 19, 2023
@stefsmeets stefsmeets deleted the fix_fair_workflow branch April 19, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants