Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

539 polish notebook rise timeseries #540

Merged
merged 15 commits into from
Apr 4, 2023

Conversation

geek-yang
Copy link
Member

In this PR, we re-organize the tutorial notebook of rise for timeseries to make it more user-friendly content-wise.

It will include two examples:

  • Verify RISE for timeseries with a simple "expert" model
  • Demonstrate RISE with a pretrained weather forecast (onnx) model

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@geek-yang
Copy link
Member Author

Not sure why there are many commits named "
Merge branch 'main' of github.com:dianna-ai/dianna into main". I didn't do any merge operation in this PR. But I will squash all commits when merging to the main, to avoid this messy history.

@geek-yang geek-yang requested a review from cwmeijer April 1, 2023 12:46
@geek-yang
Copy link
Member Author

The second example in the notebook now is a binary forecast. I think it is nice to show a multi-variate case. We can change it when the multi-channel masking is available.

@geek-yang geek-yang marked this pull request as ready for review April 1, 2023 12:49
@geek-yang
Copy link
Member Author

Note for merging: Please use "squash and merge".

@cwmeijer cwmeijer force-pushed the 539-polish_notebook_RISE_timeseries branch from 0ef2e55 to b5a1e1e Compare April 4, 2023 08:48
Copy link
Contributor

@cwmeijer cwmeijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent changes!

@cwmeijer cwmeijer merged commit a92dd4f into main Apr 4, 2023
@cwmeijer cwmeijer deleted the 539-polish_notebook_RISE_timeseries branch April 4, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants