Fix bug with label uploads #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @laurasootes would you be willing to review this? |
laurasootes
approved these changes
Apr 5, 2023
There was a problem hiding this comment.
Works perfectly and I also like the automatic fixes to the code formatting :)
I do have one suggestion to fix the related problem that text analysis cannot be run if the dashboard is started outside of the dashboard folder. This is caused by the hardcode word_vector_path:
word_vector_path = '../tutorials/data/movie_reviews_word_vectors.txt'
A fix could be:
word_vector_path = str(Path(os.path.dirname(os.path.dirname(file))) / 'tutorials/data/movie_reviews_word_vectors.txt')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug with label uploads where you cannot upload data outside the
FOLDER_ON_SERVER. If labels are uploaded, look at the contents of the upload instead of the filename.Closes #505