Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run CI only on PRs ready for review #533

Merged
merged 4 commits into from
Mar 28, 2023
Merged

Run CI only on PRs ready for review #533

merged 4 commits into from
Mar 28, 2023

Conversation

stefsmeets
Copy link
Contributor

This PR adds a line to only run the CI on PRs that are ready for review. For more info see the issue.

Closes #519

@stefsmeets stefsmeets mentioned this pull request Mar 28, 2023
Closed
@stefsmeets stefsmeets marked this pull request as draft March 28, 2023 12:11
@stefsmeets
Copy link
Contributor Author

@cwmeijer I updated the CI to always run linting / ubuntu with python 3.10 on all commits as we discussed.

@stefsmeets stefsmeets marked this pull request as ready for review March 28, 2023 12:16
cwmeijer
cwmeijer approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@cwmeijer cwmeijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! No surprises. Makes a lot of sense. Thanks!

@stefsmeets stefsmeets merged commit c755932 into main Mar 28, 2023
@stefsmeets stefsmeets deleted the fix_draft_tests branch March 28, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwmeijer cwmeijer cwmeijer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix github actions running when PR is in draft state
2 participants
@stefsmeets @cwmeijer