Make paths independent in notebooks #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Hi @elboyran Could you have a look at this PR and let me know if this is what you had in mind? |
|
Huh, not entirely sure why the github action fails. It works on my pc, but seems to fail here. I will have a look later today. |
elboyran
approved these changes
Mar 14, 2023
There was a problem hiding this comment.
Hi @stefsmeets , yes, that's exactly what I had in mind, thanks.
Hopefully the checks work, so we can merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the paths in all the notebooks OS independent using
pathlib.Path.Sorry for the large diff, it's collateral damage from not being to edit a single line in a jupyter notebook without updating the entire file 😅
Closes #501