Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added label file upload for text #495

Merged
merged 8 commits into from
Mar 7, 2023
Merged

Added label file upload for text #495

merged 8 commits into from
Mar 7, 2023

Conversation

cpranav93
Copy link
Contributor

@laurasootes, I have added label file upload support to text as well. However, I am not able to test it due to WSL issues for text. Could you give it a go and let me know if it works fine?

dashboard/callbacks.py Outdated Show resolved Hide resolved
Copy link
Contributor

@laurasootes laurasootes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is not working yet, somehow it is using the second character (can even be a space) of the input string as prediction label:

image

image

@cpranav93
Copy link
Contributor Author

The label issue should be fixed now. Could you give it a test? @laurasootes

Copy link
Contributor

@laurasootes laurasootes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works and looks good! If you can remove this one redundant print statement it is ready to go :)

@@ -537,9 +559,10 @@ def update_multi_options_t(fn_m, input_text, sel_methods, new_model, new_text,
onnx_model_path, word_vector_path, max_filter_size=5)

try:
print ('label:', labelnames)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this print statement

@cpranav93 cpranav93 merged commit 3440975 into main Mar 7, 2023
@cpranav93 cpranav93 deleted the 458-label-file-for-text branch March 7, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants