Cache python install in github actions #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefsmeets
changed the title
|
Hi @cwmeijer Could you have a look at this PR? |
cwmeijer
approved these changes
Feb 22, 2023
| - opened | ||
| - reopened | ||
| - synchronize | ||
| - ready_for_review | ||
| pull_request: | ||
| branches: | ||
| - main |
There was a problem hiding this comment.
I haven't worked a lot with filters and trigger types etc but this doesn't look how I'd expect it to.
To me this reads like:
We run the workflow if anything is pushed to main, and I'm not sure how to interpret these triggers in this case.
We also run the workflow on PRs when their base is main (using the default triggers as nothing is specified under this).
In other words, shouldn't the types element and it's children be under pull_request instead of under push?
There was a problem hiding this comment.
Yep, good point, I will fix this later today 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR caches the python environment. This will significantly reduce the time it will take to run the tests on github actions.
All steps should run roughly 2-3x faster now. I also made it so that the tests only run when the PR is ready for review. This helps save cpu cycles, and saving cpu cycles is good for the environment 🌱
Closes #475