Unpin prospector #442
Merged
Unpin prospector #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 1.8.4 should have fixed the issues previously mentioned in #423. See https://github.com/PyCQA/prospector/milestone/7?closed=1.
|
The linter runs, so I think this should be considered an improvement over pinning the old version? The failures are due to actual linter suggestions, which I guess are a separate issue :) |
elboyran
added this to Ready for review
in Sprint 24: Research relevance maps properties; XAI methods for TS implementatation start
loostrum
approved these changes
Jan 16, 2023
There was a problem hiding this comment.
Nice, good that the linter is running again. I agree with unpinning prospector and creating a separate issue for the linting problems. The pylint version pin was unrelated, that was already there before the prospect pin. I don't know why and I'm tempted to just unpin pylint as well, because I don't see why it was pinned in the first place.
|
I don't remember anything about pinning prospector. It doesn't seem sensible to me to pin the version of a well maintained linter package. Unpin it :-) |
Closed
cwmeijer
moved this from Ready for review
to Done
in Sprint 24: Research relevance maps properties; XAI methods for TS implementatation start
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 1.8.4 should have fixed the issues previously mentioned in #423. See https://github.com/PyCQA/prospector/milestone/7?closed=1. Also relevant to the discussion in NLeSC/python-template#327