-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
429 implement recent dashboard layout changes to text tab #438
429 implement recent dashboard layout changes to text tab #438
Conversation
…mplement-recent-dashboard-layout-changes-to-text-tab
Hey @laurasootes, could you provide me with the model for testing the text explanations? I currently only have the onnx model for the images. Thanks! |
The model is already in the repo under app_data. It is the movie review model. |
@cpranav93, could you let me know what problem you faced when trying to run the dashboard? I can't find it. |
Hey @laurasootes, I am trying out the dashboard>text and no matter what text I give, I get an error (see attached screenshot). I am not sure if I am doing something wrong here. |
but can you find where and why it is going wrong in the code? |
I had a look at where the error was happening and it is in line 546: I do not know enough about dash to figure out yet why this is causing an exception which gives the error message. Also, I noticed that when I refresh the page, and input just the text and model without the method, it raises This can be fixed in line 489 by changing it to: |
dashboard/layouts.py
Outdated
figure = utilities.blank_fig())], | ||
className = 'row', | ||
style = { | ||
'margin-top': '80', | ||
'margin-left': '140px', | ||
'height': '100px' | ||
}) | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The extra blank space at the end is not needed here :)
I added/translated the changes made to the text page of the dashboard (update and stop button, selection of model, parameters of model).
Everything seems to work, except for the issues that I created (#435 and #437 ), which are not problems in the translation but merely problems that already existed in the text page that we did not know.
This branches also fixes the linting error about the tensor flow version