Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

429 implement recent dashboard layout changes to text tab #438

Merged

Conversation

laurasootes
Copy link
Contributor

@laurasootes laurasootes commented Jan 10, 2023

I added/translated the changes made to the text page of the dashboard (update and stop button, selection of model, parameters of model).
Everything seems to work, except for the issues that I created (#435 and #437 ), which are not problems in the translation but merely problems that already existed in the text page that we did not know.

This branches also fixes the linting error about the tensor flow version

@cpranav93
Copy link
Contributor

Hey @laurasootes, could you provide me with the model for testing the text explanations? I currently only have the onnx model for the images. Thanks!

@laurasootes
Copy link
Contributor Author

The model is already in the repo under app_data. It is the movie review model.

@laurasootes laurasootes linked an issue Jan 10, 2023 that may be closed by this pull request
@laurasootes laurasootes linked an issue Jan 10, 2023 that may be closed by this pull request
@laurasootes
Copy link
Contributor Author

@cpranav93, could you let me know what problem you faced when trying to run the dashboard? I can't find it.

@cpranav93
Copy link
Contributor

Hey @laurasootes, I am trying out the dashboard>text and no matter what text I give, I get an error (see attached screenshot). I am not sure if I am doing something wrong here.

image

@laurasootes
Copy link
Contributor Author

but can you find where and why it is going wrong in the code?

@cpranav93
Copy link
Contributor

cpranav93 commented Jan 12, 2023

I had a look at where the error was happening and it is in line 546:
hti = Html2Image()

I do not know enough about dash to figure out yet why this is causing an exception which gives the error message.

Also, I noticed that when I refresh the page, and input just the text and model without the method, it raises
'There was an error running the model. Check either the test text or the model.'
but it should raise:
'Missing model, input text or XAI method.'

This can be fixed in line 489 by changing it to:
if (fn_m and input_text) is not None and sel_methods is not None and sel_methods != []:

figure = utilities.blank_fig())],
className = 'row',
style = {
'margin-top': '80',
'margin-left': '140px',
'height': '100px'
})
})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extra blank space at the end is not needed here :)

@laurasootes laurasootes merged commit 81b86fb into main Jan 17, 2023
@laurasootes laurasootes deleted the 429-implement-recent-dashboard-layout-changes-to-text-tab branch January 17, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants