Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

386 dashboard selection method for xai method #416

Merged
merged 9 commits into from
Dec 2, 2022

Conversation

laurasootes
Copy link
Contributor

This pull request creates a checklist for selecting the XAI method instead of a dropdown

@laurasootes laurasootes linked an issue Nov 28, 2022 that may be closed by this pull request
@cpranav93
Copy link
Contributor

cpranav93 commented Nov 30, 2022

It looks much better as a checklist than it did as a drop-down! Great work @laurasootes. A couple of comments:

  1. I think we no longer need to have 'import dash_bootstrap_components as dbc' in layouts.py. This can be removed. It will also fix the linter error.

  2. I see that the error message of "Missing image/model" is no longer raised under any circumstance. Is this an intentional change in the design?

A suggestion:
Could we have the three methods placed horizontally (side by side) instead of vertically? I think it might look better.

@laurasootes
Copy link
Contributor Author

Hi @cpranav93,
I fixed the first problem and your suggestion. I do indeed see that the error message is not longer accessible. It simply does not update anymore if you do not follow the correct order (i.e. if you have for example not uploaded an image). However, I think this is something that will be automatically fixed in your PR on the update button right? In that case I think it is not worth it to try to fix this here

dashboard/layouts.py Outdated Show resolved Hide resolved
@cpranav93
Copy link
Contributor

Hey @laurasootes, I think it works great. Added a comment regarding the spacing. Consider it, and whatever you decide, from my side the PR is ready to merge.

@laurasootes laurasootes merged commit f7c6042 into main Dec 2, 2022
@laurasootes laurasootes deleted the 386-dashboard-selection-method-for-xai-method branch December 2, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard: selection method for XAI method
2 participants