Minor code issues

[loostrum]

Fixes #152

The RISE tests are failing because of #119, so the PR fixing that (#125) should be merged first.

[loostrum]

I noticed a deprecation warning that I fixed as well: import display from IPython instead of from IPython.core

[loostrum]

Renaming shap.py to kernelshap.py, as the external lib we are using is also called shap so there might be import issues.

This was noted by prospector, but only with the defaults, not with the prospector.yml setup from the repo (so also missed in github actions). Pasting the different setups in case we want to debug this in the future.

With defaults on my machine:

Messages
========

shap.py
  Line: 3
    pylint: import-self / Module import itself



Check Information
=================
         Started: 2022-01-25 12:13:01.902891
        Finished: 2022-01-25 12:13:14.260074
      Time Taken: 12.36 seconds
       Formatter: grouped
        Profiles: default, no_doc_warnings, no_test_warnings, strictness_medium, strictness_high, strictness_veryhigh, no_member_warnings
      Strictness: None
  Libraries Used: 
       Tools Run: dodgy, mccabe, pep8, profile-validator, pyflakes, pylint
  Messages Found: 1

Running from repo root so it uses .prospector.yml:

Check Information
=================
         Started: 2022-01-25 12:14:26.706619
        Finished: 2022-01-25 12:14:40.103541
      Time Taken: 13.40 seconds
       Formatter: grouped
        Profiles: .prospector.yml, full_pep8, doc_warnings, strictness_medium, strictness_high, strictness_veryhigh, no_member_warnings
      Strictness: from profile
  Libraries Used: 
       Tools Run: dodgy, mccabe, pep257, pep8, profile-validator, pyflakes, pylint, pyroma
  Messages Found: 0

[egpbos]

Seems tests are failing due to the locals error in get_kwargs_applicable_to_function, right?

[egpbos]

Ah you already mentioned that earlier :D

[egpbos]

Hm, weird, the manual rerun of the build action doesn't merge into the latest main commit, it says HEAD is now at 39d0af8 Merge da1af8d3e6d7fcc3e4a77a0f2a150412a5f6d134 into 0edf25095dbe7d74dd6ac91e00c6af298da22802. 0edf250 is the commit before the fix for get_kwargs_applicable_to_function was merged in...

[egpbos]

Tried it again, but it still merges into the same main branch, bummer... That means that the manual "rerun workflow" buttons are pretty useless. You'll have to push a new commit (can also amend the last one and force-push it) to retry with the main fix.

[loostrum]

Aww that's too bad. I'll fix the typo in the last commit message and force-push ;)

[loostrum]

Force-pushing triggered the action again, now the RISE tests are passing so this is ready for merge once approved.

[egpbos]

LGTM!