Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New games #114

Merged
merged 9 commits into from
Apr 30, 2024
Merged

New games #114

merged 9 commits into from
Apr 30, 2024

Conversation

alexpalms
Copy link
Member

No description provided.

@alexpalms alexpalms marked this pull request as draft April 26, 2024 02:41
@@ -241,10 +242,15 @@ def _sanity_check(self):
check_val_in_list("characters[{}]".format(idx), self.characters[idx], char_list)
check_num_in_range("outfits", self.outfits, self.games_dict[self.game_id]["outfits"])
check_val_in_list("super_art", self.super_art, [None, 1, 2, 3])
check_val_in_list("fighting_style", self.fighting_style, [None, 1, 2, 3])
if self.game_id == "kof98umh":
check_val_in_list("fighting_style", self.fighting_style, [None, 1, 2, 3])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw I recently learned about https://docs.pydantic.dev which would could help improving these validations. Just something to check out whenever

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw I recently learned about https://docs.pydantic.dev which would could help improving these validations. Just something to check out whenever

Thanks a lot for the suggestion, will add this as a task!

@discordianfish
Copy link
Member

But see test failures

@alexpalms
Copy link
Member Author

But see test failures

Yes to be re-evaluate after the release of the new engine

@alexpalms alexpalms marked this pull request as ready for review April 30, 2024 02:45
@alexpalms alexpalms merged commit 505328f into main Apr 30, 2024
30 of 40 checks passed
@alexpalms alexpalms deleted the new-games branch April 30, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants