refactor: use shared dashboard plugin wrapper #3232
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-3232--dhis2-maps.netlify.app |
edoardo
force-pushed
the
refactor/use-platform-plugin-components
branch
from
56b135d
to
04d645c
Compare
5 tasks
edoardo
force-pushed
the
refactor/use-platform-plugin-components
branch
from
26d68bb
to
0330221
Compare
edoardo
force-pushed
the
refactor/use-platform-plugin-components
branch
from
0330221
to
258354c
Compare
First test if the app works without and create a new patch file if it doesn't afterwards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the fix for: DHIS2-17268
Requires dhis2/analytics#1672
Key features
Description
Generic components for plugins are available in
app-platformandapp-runtime.Analytics apps are currently having the same components replicated in each repo, a shared dashboard plugin wrapper has been added in
analytics.Known issues
Screenshots